-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using string formatter for range aggregations. Closes #4432 & #4404 #4434
Conversation
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
@spalger any updates? |
Sorry @gauravsinghania I've been aggressively trying to get merged and will get to this soon |
@spalger no worries, thanks. |
Hey @gauravsinghania, I merged master and updated the changes to match the date_range aggregation's implementation. Would you mind taking a look at my pull against your fork and merging it when you get a chance? |
@spalger thanks, I will have a look. |
@gauravsinghania the change list looks daunting, but that's because it merges master. If you merge it into your pull request (just hit the green button) then we can move forward with this pull. |
@spalger it was delayed because so far I was using es 1.5.2 and the kibana master doesn't work with it. Is there a work around or I need to use es 2.0. Also if I have to use es 2.0 do i need to get the code or is there any binary available for it (in the repo I can only see executable till 1.7.1) . |
convert format changing to match date_range
@gauravsinghania, thanks so much for taking the initiative here. The more I played with this the more it inspired another approach, which I have taken in #4613. Please take a look at that pr and let me know if it works for you. For now I'm going to close this as the other PR includes these changes. |
@spalger thanks a lot. I will have a look at the other PR. |
For an aggregations the field format used depends on the field type. For a number field the x-axis labels are NaN and a numberic formatter would give wrong results, hence forcing a string formatter for a range aggregations. Closes #4432 & #4404